Remove unused config params#1276
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Jul 22, 2021
Merged
Conversation
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Feb 6, 2024
DSC-1491 - Infinite scroll on modal fix Approved-by: Vincenzo Mecca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR removes the config properties
rewriteDownloadUrlsandlogDirectorybecause they are no longer used.It also fixes the
getRequestOrigin()method inServerHardRedirecService: it used to return thehost, not theorigin. I've renamed the method and updated the typdocs to make its purpose clearer.Instructions for Reviewers
You can verify that the origin is correct by checking e.g. the citation_pdf_url meta tag on an item page while javascript is disabled. It should now contain both the scheme and the port.
Checklist
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.