Skip to content

Remove unused config params#1276

Merged
tdonohue merged 2 commits intoDSpace:mainfrom
atmire:remove-unused-config-params
Jul 22, 2021
Merged

Remove unused config params#1276
tdonohue merged 2 commits intoDSpace:mainfrom
atmire:remove-unused-config-params

Conversation

@artlowel
Copy link
Copy Markdown
Member

References

Description

This PR removes the config properties rewriteDownloadUrls and logDirectory because they are no longer used.

It also fixes the getRequestOrigin() method in ServerHardRedirecService: it used to return the host, not the origin. I've renamed the method and updated the typdocs to make its purpose clearer.

Instructions for Reviewers

You can verify that the origin is correct by checking e.g. the citation_pdf_url meta tag on an item page while javascript is disabled. It should now contain both the scheme and the port.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@artlowel artlowel added the 1 APPROVAL pull request only requires a single approval to merge label Jul 22, 2021
@artlowel artlowel added this to the 7.0 milestone Jul 22, 2021
@artlowel artlowel requested a review from tdonohue July 22, 2021 16:49
@artlowel artlowel self-assigned this Jul 22, 2021
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks correct & it works for me. Thanks @artlowel for the quick fixes & the improvements here. Merging immediately as these are minor changes, but necessary for 7.0

@tdonohue tdonohue merged commit fa02d1e into DSpace:main Jul 22, 2021
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Feb 6, 2024
DSC-1491 - Infinite scroll on modal fix

Approved-by: Vincenzo Mecca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants