Skip to content

SEO + SSR fixes: Fix <meta> tag syntax and add a basic test that SSR is working#1282

Merged
tdonohue merged 2 commits intoDSpace:mainfrom
tdonohue:test_ssr_working
Jul 26, 2021
Merged

SEO + SSR fixes: Fix <meta> tag syntax and add a basic test that SSR is working#1282
tdonohue merged 2 commits intoDSpace:mainfrom
tdonohue:test_ssr_working

Conversation

@tdonohue
Copy link
Copy Markdown
Member

@tdonohue tdonohue commented Jul 26, 2021

References

Description

This PR makes two small improvements for SEO + SSR. While these two improvements are not directly related, they are both necessary to improve SEO + SSR in version 7.0

  1. First, modify the syntax of our <meta> tags slightly. Currently all meta tags use a property attribute (e.g. <meta property="" content=""/>) when they are supposed to use a name attribute (e.g. <meta name="" content=""/>) like in 6.x. This is a minor, but important, issue as the HTML5 <meta> tag only has a name attribute. See this good SO answer. See this commit for the change 7fcd055
  2. Second, add a basic "smoke test" that server-side rendering is working properly to our GitHub CI build.yml. As you can see from the code, this "smoke test" looks for one of our <meta> tags in the server-side rendered output to verify that basic SEO + SSR is functioning.

Instructions for Reviewers

  1. Check that <meta> tags now use name instead of property
  2. Verify that "smoke test" of SSR works in GitHub CI

@tdonohue tdonohue added this to the 7.0 milestone Jul 26, 2021
@tdonohue tdonohue self-assigned this Jul 26, 2021
@tdonohue
Copy link
Copy Markdown
Member Author

I've verified the changes in this PR locally, additionally:

  • All code changes are verified by specs
  • GitHub CI changes are successful in this PR build process

Therefore, I'm going to merge this PR immediately in order to facilitate final testing this week, prior to 7.0. That said, if @artlowel or @atarix83 notice anything of concern tomorrow (in this PR or on the demo site), I will revert/fix as needed.

@tdonohue tdonohue merged commit 47302ac into DSpace:main Jul 26, 2021
@tdonohue tdonohue deleted the test_ssr_working branch July 26, 2021 20:49
steph-ieffam pushed a commit to 4Science/dspace-angular that referenced this pull request Jan 26, 2024
CST-13397 - fine tune UI

Approved-by: Stefano Maffei
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant