SEO + SSR fixes: Fix <meta> tag syntax and add a basic test that SSR is working#1282
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Jul 26, 2021
Merged
SEO + SSR fixes: Fix <meta> tag syntax and add a basic test that SSR is working#1282tdonohue merged 2 commits intoDSpace:mainfrom
tdonohue merged 2 commits intoDSpace:mainfrom
Conversation
806ba16 to
0b7e39d
Compare
0b7e39d to
91bb5e2
Compare
Member
Author
|
I've verified the changes in this PR locally, additionally:
Therefore, I'm going to merge this PR immediately in order to facilitate final testing this week, prior to 7.0. That said, if @artlowel or @atarix83 notice anything of concern tomorrow (in this PR or on the demo site), I will revert/fix as needed. |
steph-ieffam
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Jan 26, 2024
CST-13397 - fine tune UI Approved-by: Stefano Maffei
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR makes two small improvements for SEO + SSR. While these two improvements are not directly related, they are both necessary to improve SEO + SSR in version 7.0
<meta>tags slightly. Currently all meta tags use apropertyattribute (e.g.<meta property="" content=""/>) when they are supposed to use anameattribute (e.g.<meta name="" content=""/>) like in 6.x. This is a minor, but important, issue as the HTML5<meta>tag only has anameattribute. See this good SO answer. See this commit for the change 7fcd055build.yml. As you can see from the code, this "smoke test" looks for one of our<meta>tags in the server-side rendered output to verify that basic SEO + SSR is functioning.Instructions for Reviewers
<meta>tags now usenameinstead ofpropertymainbefore If there's no correlation ID cookie, server side rendering crashes #1279 was applied. This resulted in failures of the SSR test. See this example: https://github.com/tdonohue/dspace-angular/runs/3164437546?check_suite_focus=truemain, this PR's tests should succeed