Skip to content

move embargo action buttons to the bottom#1383

Closed
paulo-graca wants to merge 1 commit intomainfrom
fix-usability-issue-1382
Closed

move embargo action buttons to the bottom#1383
paulo-graca wants to merge 1 commit intomainfrom
fix-usability-issue-1382

Conversation

@paulo-graca
Copy link
Copy Markdown
Contributor

References

Description

Simple HTML change to move embargo action buttons to the bottom of that specific bitstream section.

Instructions for Reviewers

  • at the submission form, at the upload section, where you can edit embargo, the actions buttons moved from the top to bottom of that bitstream section, being present for the user. This PR doesn't fix the autosave part of the issue.

@paulo-graca paulo-graca self-assigned this Oct 29, 2021
@tdonohue tdonohue self-requested a review November 4, 2021 14:33
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Nov 4, 2021
@tdonohue
Copy link
Copy Markdown
Member

@paulo-graca : I appreciate this small PR to fix to provide slightly better usability. However, I'm going to close this in favor of a larger usability fix as proposed in #1399 I hope you'll agree that, once this entire section uses a popup modal, the saving behavior will be vastly improved and these current buttons will no longer be necessary at all.

In the meantime, if you or anyone else using 7.0 or 7.1 run into this issue, I do think your PR here is a perfectly OK "quick fix". It'll just be immediately obsolete once #1399 is fixed.

@tdonohue tdonohue closed this Nov 10, 2021
@tdonohue tdonohue deleted the fix-usability-issue-1382 branch February 2, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: submission usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usability issue in Embargo's section at submission

2 participants