move embargo action buttons to the bottom#1383
Closed
paulo-graca wants to merge 1 commit intomainfrom
Closed
Conversation
Member
|
@paulo-graca : I appreciate this small PR to fix to provide slightly better usability. However, I'm going to close this in favor of a larger usability fix as proposed in #1399 I hope you'll agree that, once this entire section uses a popup modal, the saving behavior will be vastly improved and these current buttons will no longer be necessary at all. In the meantime, if you or anyone else using 7.0 or 7.1 run into this issue, I do think your PR here is a perfectly OK "quick fix". It'll just be immediately obsolete once #1399 is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Simple HTML change to move embargo action buttons to the bottom of that specific bitstream section.
Instructions for Reviewers