Handling very long strings for metadata and file names#1458
Merged
tdonohue merged 3 commits intoDSpace:mainfrom Dec 17, 2021
Merged
Handling very long strings for metadata and file names#1458tdonohue merged 3 commits intoDSpace:mainfrom
tdonohue merged 3 commits intoDSpace:mainfrom
Conversation
…it metadata/bitstreams page
…d fixed breadcrumb overflow
|
Tested. With this PR, text properly wraps instead of overflowing if too long for the field. Approved 👍 |
tdonohue
approved these changes
Dec 17, 2021
Member
There was a problem hiding this comment.
👍 Code looks good to me, and I also gave it a quick test and it looks to fix the bug. Thanks @LotteHofstede !
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Apr 8, 2024
DSC-1556 Approved-by: Stefano Maffei
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR makes sure very long words and urls for metadata and file names don't overflow on the Edit Item Page and Item page.
For the file names on the item's
edit/bitstreampage and titles in the trail, the word should be truncated and end in an ellipsis. For all other occurrences, the .dont-break-out class was added.Instructions for Reviewers
Metadata:
/metadatatab.Title metadata:
/metadatatab, in the trail and the list view.File names:
/bitstreamstab.Checklist
yarn run lint(*) This code does not contain new tests or TypeDoc as the changes are all CSS changes