Skip to content

Fix submission upload #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tdonohue merged 2 commits into from
Jan 28, 2022
Merged

Fix submission upload #1507

tdonohue merged 2 commits into from
Jan 28, 2022

Conversation

@atarix83
Copy link
Contributor

@atarix83 atarix83 commented Jan 28, 2022 •
edited by tdonohue
Loading

References

Description

Fixes bug reported

Instructions for Reviewers

check if bug repoorted are fixed

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@atarix83 atarix83 requested a review from tdonohue January 28, 2022 13:45
@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge bug component: submission labels Jan 28, 2022
@tdonohue tdonohue added this to the 7.2 milestone Jan 28, 2022
tdonohue
tdonohue approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @atarix83 ! The code changes are tiny & look good. I've tested this and verified that both upload bugs are fixed

@tdonohue tdonohue merged commit ccdba9b into DSpace:main Jan 28, 2022
@abollini abollini deleted the fix_submission_upload branch January 28, 2022 16:58
@ybnd ybnd mentioned this pull request Feb 15, 2022
Merged
6 tasks
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request May 28, 2024
@Simone-Ramundi @vins01-4science
Merged in DSC-1594 (pull request DSpace#1507)
5fd3e79 
DSC-1594

Approved-by: Vincenzo Mecca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdonohue tdonohue tdonohue approved these changes

Assignees

@atarix83 atarix83

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: submission high priority

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

Deposit immediately after a file upload will not work properly Workflow reviewer cannot upload files to the workflowitems

2 participants

@atarix83 @tdonohue