Skip to content

Adding missing parameters to fr.json5 #1536

Merged
tdonohue merged 2 commits intoDSpace:mainfrom
pilasou:main
Mar 3, 2022
Merged

Adding missing parameters to fr.json5 #1536
tdonohue merged 2 commits intoDSpace:mainfrom
pilasou:main

Conversation

@pilasou
Copy link
Copy Markdown
Contributor

@pilasou pilasou commented Feb 22, 2022

Hi!

Description

A few parameters were missing in the fr.json5, I have added them and provided a french translation for each.
Thanks!

Adding all missing sorting parameters and their translation in french.
Adding missing parameter and their French translation.
@tdonohue
Copy link
Copy Markdown
Member

Thanks @pilasou ! I'll add this to our 7.3 project board and make sure it is reviewed for the 7.3 release.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs labels Feb 23, 2022
@tdonohue tdonohue added this to the 7.3 milestone Feb 23, 2022
@tdonohue tdonohue self-requested a review March 3, 2022 15:53
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @pilasou ! I gave this a review (using Google Translate) and spun it up to make sure it looks to be working. It all looks great. Merging this immediately so that it will be included in 7.3

@tdonohue tdonohue merged commit 3cbebdb into DSpace:main Mar 3, 2022
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Apr 8, 2024
[DSC-1621] fix authority value on submission

Approved-by: Stefano Maffei
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants