Adding Bengali Language Support#1570
Closed
raihantopu wants to merge 8 commits intoDSpace:mainfrom
raihantopu:main
Closed
Adding Bengali Language Support#1570raihantopu wants to merge 8 commits intoDSpace:mainfrom raihantopu:main
raihantopu wants to merge 8 commits intoDSpace:mainfrom
raihantopu:main
Conversation
adding Bengali language translation bn.json5 for internationalization
adding language code to config.json file
{
"code": "bn",
"label": "বাংলা",
"active": true
}
this file holds this code
{
"code": "bn",
"label": "বাংলা",
"active": true
}
without this test 12.x and 14.x is not passing (showing 'should display translated title "DSpace Angular :: Home" ')
Member
|
@raihantopu : It looks like this PR has accidentally changed too many files. Ideally, to add Bengali, all we'd really need to the new If you could just submit us a PR with only the |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
en.json5 translated to bn.json5 for (bengali language)
DSpace is one of the most used software for Institutional Repository in Bangladesh, adding 'bengali' support will have a huge impact on user interaction and satisfaction.
I have tested my changes on my local computer every thing seems to work fine on my local machine. I have just added bn.json5 file to src/assets/i18n and language code to environment.test.ts file
{
"code": "bn",
"label": "বাংলা",
"active": true
}
This is my first contribution to DSpace, if there are any mistake and need to update kindly let me know.
Regards
Md. Topu Raihan
Graduate Dept. of Information Science & Library Management