[CST-5677] Improve item authorization page#1664
Conversation
|
Thanks @davide-negretti . I've assigned this to @artlowel and I to look at whether it's possible to include in 7.3. @artlowel feel free to delegate as you see fit, I just figured that the Atmire team might want to have feedback into the modified design of this page (see description above) |
artlowel
left a comment
There was a problem hiding this comment.
Thanks @davide-negretti!
I like the redesign. It's a big improvement over the current version.
I just have a few inline suggestions
There was a problem hiding this comment.
Thanks @davide-negretti ! I agree that this is a much better user experience & it works exactly as described. On top of @artlowel 's prior feedback, I just have a few very minor suggestions. Once all the feedback is addressed, I'll gladly re-test & rereview.
(Sidenote: We likely should also sometime put the object name on the authorization policy edit page too. Currently /items/[uuid]/edit/authorizations/edit?policyId=[id] just shows "Edit resource policy [id]". But this can be done in a separate PR, as this current PR is already a much improved experience.)
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @davide-negretti ! All my feedback has been addressed, and it works well.
|
Merging as this is at +2. Thanks again @davide-negretti ! |
Task/dspace cris 2023 02 x/DSC-880
References
Description
Instructions for Reviewers
This item can be used for testing:
https://demo7.dspace.org/items/ac97ee67-2f67-4b6f-8bd0-a32e99c35cd9/edit/authorizations
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.