Skip to content

[CST-5677] Improve item authorization page#1664

Merged
tdonohue merged 11 commits intoDSpace:mainfrom
4Science:CST-5677
Jun 13, 2022
Merged

[CST-5677] Improve item authorization page#1664
tdonohue merged 11 commits intoDSpace:mainfrom
4Science:CST-5677

Conversation

@davide-negretti
Copy link
Copy Markdown
Contributor

@davide-negretti davide-negretti commented May 25, 2022

References

Description

  • Item authorization page now shows the name of the item, the bundles, and the bitstream.
  • Bitstreams' policies are now grouped below their specific bundle (a button allows to show them)
  • Only 6 bundles are shown (a button allows to show the remaining ones)

image
image

Instructions for Reviewers

This item can be used for testing:
https://demo7.dspace.org/items/ac97ee67-2f67-4b6f-8bd0-a32e99c35cd9/edit/authorizations

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@davide-negretti davide-negretti marked this pull request as ready for review May 26, 2022 14:23
@tdonohue tdonohue added bug usability authorization related to authorization, permissions or groups labels May 26, 2022
@tdonohue tdonohue added this to the 7.3 milestone May 26, 2022
@tdonohue tdonohue requested review from artlowel and tdonohue May 26, 2022 14:43
@tdonohue
Copy link
Copy Markdown
Member

Thanks @davide-negretti . I've assigned this to @artlowel and I to look at whether it's possible to include in 7.3. @artlowel feel free to delegate as you see fit, I just figured that the Atmire team might want to have feedback into the modified design of this page (see description above)

Copy link
Copy Markdown
Member

@artlowel artlowel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davide-negretti!

I like the redesign. It's a big improvement over the current version.

I just have a few inline suggestions

Comment thread package.json Outdated
Comment thread src/assets/i18n/en.json5 Outdated
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davide-negretti ! I agree that this is a much better user experience & it works exactly as described. On top of @artlowel 's prior feedback, I just have a few very minor suggestions. Once all the feedback is addressed, I'll gladly re-test & rereview.

(Sidenote: We likely should also sometime put the object name on the authorization policy edit page too. Currently /items/[uuid]/edit/authorizations/edit?policyId=[id] just shows "Edit resource policy [id]". But this can be done in a separate PR, as this current PR is already a much improved experience.)

Comment thread src/assets/i18n/en.json5 Outdated
@davide-negretti
Copy link
Copy Markdown
Contributor Author

@tdonohue @artlowel I made the requested changes

@tdonohue tdonohue requested review from artlowel and tdonohue June 9, 2022 17:01
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @davide-negretti ! All my feedback has been addressed, and it works well.

Copy link
Copy Markdown
Member

@artlowel artlowel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdonohue
Copy link
Copy Markdown
Member

Merging as this is at +2. Thanks again @davide-negretti !

4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authorization related to authorization, permissions or groups bug usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Item authorization page is not usable by normal users

4 participants