Skip to content

update fi.json#1685

Merged
tdonohue merged 2 commits intoDSpace:mainfrom
reetagithub:main
Jun 13, 2022
Merged

update fi.json#1685
tdonohue merged 2 commits intoDSpace:mainfrom
reetagithub:main

Conversation

@reetagithub
Copy link
Copy Markdown
Contributor

References

Add references/links to any related issues or PRs. These may include:

  • Fixes #[issue-number]
  • Requires DSpace/DSpace#[pr-number] (if a REST API PR is required to test this)

Description

reformulated some keys, mostly 'admin' and 'administrative'

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

Modified some keys to harmonize the translations of term 'administrative'. Also, translated "Administer Workflow" to a verb instead of a noun.
@tdonohue tdonohue self-requested a review June 13, 2022 14:13
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Jun 13, 2022
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @reetagithub ! I installed this and did a quick "sanity check" and it looks to be working. Merging immediately.

@tdonohue tdonohue merged commit 50f9688 into DSpace:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants