Skip to content

Enable responsive font sizes#1786

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
hardyoyo:enable-responsive-font-sizes
Aug 31, 2022
Merged

Enable responsive font sizes#1786
tdonohue merged 1 commit intoDSpace:mainfrom
hardyoyo:enable-responsive-font-sizes

Conversation

@hardyoyo
Copy link
Copy Markdown
Member

  • adds enable-responsive-font-sizes toggle to the main bootstrap
    variables scss file
  • docs available

References

  • discussed on DSpace slack, tested by myself and @mspalti

Description

This PR adds the enable-responsive-font-sizes toggle to the main bootstrap variables scss file, and toggles it on.

Instructions for Reviewers

You'll need a phone to really test this change, compare the home page type with and without this toggle turned on. With it on, the home page content better fits the phone's viewport, and is thus more usable.

List of changes in this PR:

  • adds the enable-responsive-font-sizes toggle to the main bootstrap variables scss file, and toggles it on

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

As mentioned above, you'll need a phone to test this, or your can use your browser's developer tools, to adjust the viewport to match a phone screen.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

- adds enable-responsive-font-sizes toggle to the main bootstrap
  variables scss file
- [docs available](https://getbootstrap.com/docs/4.4/content/typography/#responsive-font-sizes)
@tdonohue tdonohue added usability themes 1 APPROVAL pull request only requires a single approval to merge labels Aug 23, 2022
@tdonohue tdonohue added this to the 7.4 milestone Aug 23, 2022
@tdonohue tdonohue requested review from mspalti and tdonohue August 23, 2022 21:12
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @hardyoyo ! I've tested this using the mobile device toolbar in Chrome (which attempts to mimic a mobile device). It definitely looks a ton better with this setting than without it & I do see that the fonts are scaled more appropriately. Also tested with both 'dspace' and 'custom' themes and it works well for both.

@tdonohue
Copy link
Copy Markdown
Member

Merging immediately as this was already previously tested by @mspalti who gave positive feedback via Slack.

@tdonohue tdonohue merged commit eee0d72 into DSpace:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge themes usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants