Enable responsive font sizes#1786
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Aug 31, 2022
Merged
Conversation
- adds enable-responsive-font-sizes toggle to the main bootstrap variables scss file - [docs available](https://getbootstrap.com/docs/4.4/content/typography/#responsive-font-sizes)
tdonohue
approved these changes
Aug 31, 2022
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @hardyoyo ! I've tested this using the mobile device toolbar in Chrome (which attempts to mimic a mobile device). It definitely looks a ton better with this setting than without it & I do see that the fonts are scaled more appropriately. Also tested with both 'dspace' and 'custom' themes and it works well for both.
Member
|
Merging immediately as this was already previously tested by @mspalti who gave positive feedback via Slack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
variables scss file
References
Description
This PR adds the enable-responsive-font-sizes toggle to the main bootstrap variables scss file, and toggles it on.
Instructions for Reviewers
You'll need a phone to really test this change, compare the home page type with and without this toggle turned on. With it on, the home page content better fits the phone's viewport, and is thus more usable.
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
As mentioned above, you'll need a phone to test this, or your can use your browser's developer tools, to adjust the viewport to match a phone screen.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.