Cookie consent shows analytics usage also when GA is disabled

[vins01-4science]

References

• Fixes Cookie consent shows analytics usage also when GA is disabled #1731

Description

This PR hides the analytics accordion when the api-key is not configured or is left blank on the server-side

Instructions for Reviewers

You can check this PR by changing the property field google.analytics.key inside the dspace.cfg configuration file.
The expected behaviour for google.analytics.key value is:

• Empty or null: Hide the section analytics inside the cookie consent popup
• Other values: Show the section analytics inside the cookie consent popup

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes TSLint validation using yarn run lint
• My PR doesn't introduce circular dependencies
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[ybnd]

Functionally everything looks good to me, I've mainly listed some refactoring suggestions

[vins01-4science]

Hi @ybnd,

Firstly, thank you for the review.

I'm sorry but I have some doubt about your review, could you clarify them? I left some comment above.

Thank you!

[vins01-4science]

Hi @ybnd,

refactored as you told me, and added some tests for the google analytics case.

Thank you!

[ybnd]

Thanks for the refactor!
I've added a few more remarks for the specs

[vins01-4science]

Hi @ybnd,

Thank You for the review, I refactored and cleaned the specs as You told me.

[ybnd]

Thanks, the specs look good now!

[tdonohue]

👍 Thanks @vins01-4science ! The code looks good. I also tested this locally and verified that the Google Analytics section of the Klaro popup only appears when google.analytics.key is set on the backend.