Skip to content

Greek support for frontend#1819

Merged
tdonohue merged 14 commits intoDSpace:mainfrom
kostisalex:feature/greek_support_in_frontend
Sep 19, 2022
Merged

Greek support for frontend#1819
tdonohue merged 14 commits intoDSpace:mainfrom
kostisalex:feature/greek_support_in_frontend

Conversation

@kostisalex
Copy link
Copy Markdown
Contributor

References

Support for greek language in frontend

Description

Generation of el.json5 file and translation of all frontend messages in greek. The messages have been reviewed

Instructions for Reviewers

  • src/assets/i18n/el.json5
    modified: config/config.example.yml
    modified: src/config/default-app-config.ts
    modified: src/environments/environment.test.ts

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • Includes a HUGE el.json5 file with translations. My PR is small in size concerning code (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

Copy link
Copy Markdown
Contributor Author

@kostisalex kostisalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdonohue tdonohue added the i18n / l10n Internationalisation and localisation, related to message catalogs label Sep 12, 2022
@tdonohue tdonohue added this to the 7.4 milestone Sep 12, 2022
Copy link
Copy Markdown

@kominis kominis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messages are correct

Copy link
Copy Markdown
Member

@kstamatis kstamatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some misleading translations, mostly on the following:
item: "στοιχείο" instead of "εγγραφή"
bitstream: "ροή bit" or "δυαδική ροή" instead of "αρχείο"
map item: "χάρτης" instead of "αντιστοίχιση"
format: "μορφή" instead of "μορφότυπος"
bundle: "δέσμη" or "πακέτο" instead of "φάκελος/πακέτο"

I have tried to comment on some of them. There are some other that need to be changed.

Comment thread src/assets/i18n/el.json5 Outdated
Comment thread src/assets/i18n/el.json5 Outdated
Comment thread src/assets/i18n/el.json5 Outdated
Comment thread src/assets/i18n/el.json5 Outdated
Comment thread src/assets/i18n/el.json5 Outdated
Comment thread src/assets/i18n/el.json5 Outdated
Comment thread src/assets/i18n/el.json5 Outdated
Comment thread src/assets/i18n/el.json5 Outdated
Comment thread src/assets/i18n/el.json5 Outdated
Comment thread src/assets/i18n/el.json5 Outdated
@tdonohue
Copy link
Copy Markdown
Member

@kstamatis : Could you re-review this for us? Looks like the changes you suggested have been applied.

@tdonohue tdonohue requested a review from kstamatis September 14, 2022 14:30
@kostisalex
Copy link
Copy Markdown
Contributor Author

kostisalex commented Sep 15, 2022

@kstamatis @tdonohue @kominis
Some translations (pool, embargo,bit etc) make no sense (or are difficult to understand) if they are translated in greek. So, these mainly technical terms, remain in english inside the greek file : So "Back to pool"->"Πίσω στο pool" or "embargo period"->"Περίοδος embargo" ....
Thanks @kstamatis for your comments. I have accepted all of them and integrated in the translation file. Concerning some terms such as "item", that can have multiple different translations in greek ("Τεκμήριο", "Αντικείμενο", "Εγγραφή" κ.λπ. ), I adopted the one that I use myself (in this case "Τεκμήριο") and most of the times is the same with the Greek translation of this term in older versions of Dspace (v6)

@tdonohue tdonohue self-requested a review September 15, 2022 15:04
Comment thread src/assets/i18n/el.json5 Outdated
@kostisalex kostisalex requested review from tdonohue and removed request for kstamatis September 16, 2022 20:41
Copy link
Copy Markdown
Member

@kstamatis kstamatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems OK. My last review comments (pull request: kostisalex#1) were accepted by @kostisalex.

@kostisalex
Copy link
Copy Markdown
Contributor Author

kostisalex commented Sep 19, 2022

Everything seems OK. My last review comments (pull request: kostisalex#1) were accepted by @kostisalex.

Thanks @kstamatis @tdonohue for your review and changes. I guess this PR will be useful to all greek Dspace community

Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @kostisalex ! I gave this a quick test just to verify it's working & it is. Merging as this has several approvals now

@tdonohue tdonohue merged commit 31167a3 into DSpace:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants