Greek support for frontend#1819
Conversation
kstamatis
left a comment
There was a problem hiding this comment.
There are some misleading translations, mostly on the following:
item: "στοιχείο" instead of "εγγραφή"
bitstream: "ροή bit" or "δυαδική ροή" instead of "αρχείο"
map item: "χάρτης" instead of "αντιστοίχιση"
format: "μορφή" instead of "μορφότυπος"
bundle: "δέσμη" or "πακέτο" instead of "φάκελος/πακέτο"
I have tried to comment on some of them. There are some other that need to be changed.
|
@kstamatis : Could you re-review this for us? Looks like the changes you suggested have been applied. |
|
@kstamatis @tdonohue @kominis |
kstamatis
left a comment
There was a problem hiding this comment.
Everything seems OK. My last review comments (pull request: kostisalex#1) were accepted by @kostisalex.
Thanks @kstamatis @tdonohue for your review and changes. I guess this PR will be useful to all greek Dspace community |
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @kostisalex ! I gave this a quick test just to verify it's working & it is. Merging as this has several approvals now
References
Support for greek language in frontend
Description
Generation of el.json5 file and translation of all frontend messages in greek. The messages have been reviewed
Instructions for Reviewers
modified: config/config.example.yml
modified: src/config/default-app-config.ts
modified: src/environments/environment.test.ts
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.