Ensure yarn test:rest reads all JSON data, not just first chunk

[tdonohue]

References

Fixes issue reported in https://groups.google.com/g/dspace-tech/c/XU7KFZGOr94/m/aeAlQZo5BQAJ

Description

Some proxies (namely nginx) may chunk JSON data in responses from the REST API. This tiny PR ensures that the yarn test:rest script can handle chunked data.

Simply put, it updates the existing code to use the 'data' and 'end' events to ensure that we don't just read the first chunk of data, and instead keep reading until the 'end' event fires. See the docs on http.ClientRequest for more details: https://nodejs.org/api/http.html#class-httpclientrequest

Instructions for Reviewers

• Review the changes
• Test yarn test:rest on a valid REST API and ensure it works. If you happen to have a REST API where data is returned in chunks that'd be even better.

This PR is based heavily on code sent to me by Sean Kalynuk (U of Manitoba) (@uofmsean) who reported to have this fix in this thread: https://groups.google.com/g/dspace-tech/c/XU7KFZGOr94/m/yZPYL6xBCgAJ

[uofmsean]

Confirmed that this fixes the issue when testing with the REST API via http and https. Tested against both an nginx reverse proxy (http) and also our F5 load balancer (https). Ensured that both were returning chunked data while testing.

[tdonohue]

As agreed in today's Dev Meeting, I'm merging this immediately as the code was initially provided by @uofmsean ... and it has been tested by both myself and @uofmsean .

[byteAr]

Hello, what should I do exactly to solve this problem? I know maybe I should do a merge. I have Dspace 7.3 installed on my Debian 11 server. Greetings from Argentina

[tdonohue]

@byteAr : This fix was added in 7.4. The easiest way to apply this fix is to simply upgrade to 7.4.