Skip to content

After drag & drop: Redirect the user and remove the notification#1823

Merged
tdonohue merged 3 commits intoDSpace:mainfrom
nibou230:dd-submission-1765
Sep 28, 2022
Merged

After drag & drop: Redirect the user and remove the notification#1823
tdonohue merged 3 commits intoDSpace:mainfrom
nibou230:dd-submission-1765

Conversation

@nibou230
Copy link
Copy Markdown
Contributor

References

Description

Send the user directly to the submission page instead of showing a potential misleading notification.

Instructions for Reviewers

List of changes in this PR:

  • Removed the notification when uploading a single file in my-dspace-new-submission.component.ts.
  • Redirect the user to the generated link instead.
  • Removed unused translations in en.json5 and fr.json5.

See #1765 for more information about the problem and how to reproduce it.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@tdonohue tdonohue changed the title Redirect the user and remove the notification After drag & drop: Redirect the user and remove the notification Sep 14, 2022
@tdonohue tdonohue added this to the 7.4 milestone Sep 14, 2022
@tdonohue tdonohue requested a review from atarix83 September 15, 2022 14:35
@tdonohue tdonohue self-requested a review September 22, 2022 14:54
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Sep 22, 2022
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @nibou230 ! This works as described and I agree it's better behavior, as it's one less click to get to the submission form.

As a sidenote, I suspect we'll have to revisit this change if we ever find a way to support multiple file uploads (which currently is not supported, see #820). But, we can figure out the best approach to multi-file uploads whenever we implement them.

I'll leave this open for a day or two to let @atarix83 take a look (as I know he was interested in this one). But, as far as I'm concerned, I think this looks good to merge into 7.4

Copy link
Copy Markdown
Contributor

@atarix83 atarix83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nibou230 for this PR

LGTM

@nibou230
Copy link
Copy Markdown
Contributor Author

Thank you @tdonohue and @atarix83 for reviewing my PR. I'm glad I could help you a bit!

@tdonohue tdonohue merged commit 389ae85 into DSpace:main Sep 28, 2022
@nibou230 nibou230 deleted the dd-submission-1765 branch September 29, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge component: submission improvement usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve DSpace 7 drag and drop submission

3 participants