After drag & drop: Redirect the user and remove the notification#1823
Merged
tdonohue merged 3 commits intoDSpace:mainfrom Sep 28, 2022
Merged
After drag & drop: Redirect the user and remove the notification#1823tdonohue merged 3 commits intoDSpace:mainfrom
tdonohue merged 3 commits intoDSpace:mainfrom
Conversation
3966339 to
4ea2c82
Compare
4ea2c82 to
9140fb6
Compare
tdonohue
approved these changes
Sep 27, 2022
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @nibou230 ! This works as described and I agree it's better behavior, as it's one less click to get to the submission form.
As a sidenote, I suspect we'll have to revisit this change if we ever find a way to support multiple file uploads (which currently is not supported, see #820). But, we can figure out the best approach to multi-file uploads whenever we implement them.
I'll leave this open for a day or two to let @atarix83 take a look (as I know he was interested in this one). But, as far as I'm concerned, I think this looks good to merge into 7.4
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Send the user directly to the submission page instead of showing a potential misleading notification.
Instructions for Reviewers
List of changes in this PR:
my-dspace-new-submission.component.ts.en.json5andfr.json5.See #1765 for more information about the problem and how to reproduce it.
Checklist
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.