Full item page of entities missing title/name

[alexandrevryghem]

References

• Fixes Full item page of entities missing title/name #1833

Description

Use the DSONameService for displaying all the title and name fields for items.

Instructions for Reviewers

Verify for each entity and item with dspace.entity.type that it renders a valid title or a fallback if none can be found in following locations:

• Full item page
• Simple item page
• Search list view
• Search grid view
• MyDSpace search list view
• MyDSpace search grid view
• Trail/Breadcrumb

List of entity types with corresponding expected title fields:

• Person: {person.familyName}, {person.givenName} (comma and space only rendering if both present)
• OrgUnit: organization.legalName
• (Default) Publication, Project, JournalIssue, Journal, JournalVolume, untyped items and other DSO: dc.title

List of changes in this PR:

• DSONameService: For the items of type Person the comma in the title ${familyName}, ${givenName} is now only showed when both fields exist
• DSONameService: When the factories returned null or undefined the getName would still be empty now it will call the Default factory when defined factory returns an empty value
• The single item pages use the ItemPageTitleFieldComponent instead of their old h2 titles
• The children of SearchResultListElementComponent now all his use the dsoTitle field instead of retrieving it from the metadata directly
• The children of ItemSearchResultGridElementComponent now all his use the new dsoTitle field instead of retrieving it from the metadata directly

Include guidance for how to test or review your PR.

• Go over all the remaining usage of dc.title, person.familyName, person.givenName and organization.legalName and check if they can also use the DSONameService (normally they have all already been changed)

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes TSLint validation using yarn run lint
• My PR doesn't introduce circular dependencies
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[tdonohue]

@alexandrevryghem : This now has minor merge conflicts. I suspect caused by our recent merger of #1780. Could you give it a rebase on the latest main when you get the chance?

[tdonohue]

👍 Thanks @alexandrevryghem ! I tested this today and it fixes the reported bug. I also tested each out-of-the-box entity type, and didn't find any issues with their title/name in search, browse, simple item page or full item page. So, this looks great to me!