Skip to content

Conversation

@danilofjr
Copy link
Contributor

Fully translated til line 538 and other small corrections.

Fully translated til line 538 and other small corrections
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Sep 28, 2022
@tdonohue tdonohue self-requested a review September 29, 2022 13:45
@paulo-graca paulo-graca self-requested a review September 29, 2022 14:35
Copy link
Contributor

@paulo-graca paulo-graca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @danilofjr for your contribution!
I've left my thoughts and some Portuguese phrases that I think could be improved.

@danilofjr
Copy link
Contributor Author

Thank you @danilofjr for your contribution! I've left my thoughts and some Portuguese phrases that I think could be improved.

Thanks @paulo-graca for the comments and suggestions!

@paulo-graca
Copy link
Contributor

Thank you @danilofjr , can you please address the comments that we both agree on?

@danilofjr danilofjr requested review from paulo-graca and removed request for tdonohue September 30, 2022 14:34
Copy link
Contributor

@paulo-graca paulo-graca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @danilofjr for addressing my feedback. Your PR is currently failing against verification (I've requested a second check) and as soon it's ok and passes all tests, I think it could be merged. Again, many thanks for your contribution.

@tdonohue tdonohue added this to the 7.4 milestone Sep 30, 2022
@tdonohue tdonohue merged commit e1b21e2 into DSpace:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants