Skip to content

Conversation

@artlowel
Copy link
Member

@artlowel artlowel commented Oct 3, 2022

References

Description

Adds a z-index to ds-selectable-list-item-control to ensure it gets rendered higher than the thumbnail

Instructions for Reviewers

Verify that you can select a checkbox or radio button in the relationship modal

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@artlowel artlowel self-assigned this Oct 3, 2022
@artlowel artlowel requested a review from tdonohue October 3, 2022 15:14
@artlowel artlowel added 1 APPROVAL pull request only requires a single approval to merge high priority labels Oct 3, 2022
@artlowel artlowel added this to the 7.4 milestone Oct 3, 2022
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Excellent catch @artlowel ! You were 100% correct. The initial issue I had was simply that the thumbnail was overlaying the checkbox and I must have kept clicking on the thumbnail. Everything now works perfectly and there's no performance issues at all.

@tdonohue tdonohue merged commit 60c317c into DSpace:main Oct 3, 2022
@artlowel artlowel deleted the fix-z-index-issue-in-item-list-selects branch October 4, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding Relationship to existing Entity sometimes requires multiple clicks

2 participants