E2E test stabilization, and upgrade to latest Cypress v9 and axe-core#1898
E2E test stabilization, and upgrade to latest Cypress v9 and axe-core#1898tdonohue merged 3 commits intoDSpace:mainfrom
Conversation
|
This is ready for review now. While it hasn't fully stabilized all tests (After restarting tests 5 times, I did finally hit some random Axe accessibility check failures), it seems better than previously. |
|
@artlowel : This might be one you could quickly review. From what I've seen, these small changes make the e2e tests more stable, but there still will be some random failures (they seem less frequent though) |
e6c4c5d to
11154d2
Compare
|
Agreed @atarix83. I don't think this is going to fix the random failures 100% of the time, but I find the random failures are less frequent with this PR in place. I also agree that an upgrade to Cypress v10 is needed at some point...however, that's a major upgrade (I attempted it locally & found it to be quite complex & wasn't able to get it working properly -- I think v10 still is a bit buggy). In any case, merging this immediately & we'll see if this has a decent impact or if we need to prioritize a Cypress v10 upgrade sooner. |
Description
Simple PR to attempt to stabilize some randomly failing e2e tests. Based on what I've seen in recent CI runs, it looks like there are three main random failures:
This PR does the following:
axe-core.Instructions for Reviewers