Skip to content

DS-8298: fixes issue where the lastHarvested and message fields were reversed#1933

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
TexasDigitalLibrary:DSpace-8298
Oct 31, 2022
Merged

DS-8298: fixes issue where the lastHarvested and message fields were reversed#1933
tdonohue merged 1 commit intoDSpace:mainfrom
TexasDigitalLibrary:DSpace-8298

Conversation

@nwoodward
Copy link
Copy Markdown
Contributor

@nwoodward nwoodward commented Oct 27, 2022

References

Description

This issue was found during work on DSpace/DSpace#8551 in the DSpace repository. While testing that bug I noticed that the lastHarvested and message fields are reversed in the HTML template. This fixes the issue so that they're displayed next to the correct label.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge integration: OAI Harvester Related to pulling in external content via OAI harvester labels Oct 27, 2022
@tdonohue tdonohue added this to the 7.5 milestone Oct 27, 2022
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @nwoodward ! This was a obvious, but important fix. Gave it a quick test and it works as expected. The labels now align with the correct values.

@tdonohue tdonohue merged commit dc4b4ff into DSpace:main Oct 31, 2022
@nwoodward nwoodward deleted the DSpace-8298 branch May 10, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug integration: OAI Harvester Related to pulling in external content via OAI harvester

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants