Test cases of date.util.spec.ts fixed#1947
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Nov 3, 2022
Merged
Conversation
tdonohue
approved these changes
Nov 3, 2022
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @davide-negretti and @atarix83 . This looks good and makes sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Some unit tests were failing when the timezone of the OS had a positive UTC/GMT offset. This has been fixed by using UTC date format as input for the tested methods:
Instructions for Reviewers
If you live in a region where the UTC/GMT offset is negative, then change the time zone of your OS so that the UTC/GMT offset is positive (e.g. Europe Central Time, GMT+0100). You can check the offset on your browser's console:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.