Use full community, collection and item names in breadcrumb navigation#1957
Use full community, collection and item names in breadcrumb navigation#1957tdonohue merged 4 commits intoDSpace:mainfrom
Conversation
modify the breadcumbs html file to show the full name on mouseover
tdonohue
added
bug
usability
1 APPROVAL
|
@jtimal : This looks to be failing a single spec/test... the Could you look into this? It seems like it's directly related to the small changes you've made in this PR...and hopefully it'll be an easy test to fix. |
Thank you Tim, I have already made a correction and it seems to pass the tests. Thanks! |
| expectBreadcrumb(breadcrumbs[0], 'home.breadcrumbs', '/'); | ||
| expectBreadcrumb(breadcrumbs[1], 'bc 1', '/example.com'); | ||
| expectBreadcrumb(breadcrumbs[2].query(By.css('.text-truncate')), 'bc 2', null); | ||
| expectBreadcrumb(breadcrumbs[2].query(By.css('.text-truncate')), ' bc 2', null); |
There was a problem hiding this comment.
I think you can undo this change once you make the changes I described above.
There was a problem hiding this comment.
Hi @tdonohue,
I have finished with the suggestions and uploaded the changes.
Thank you very much for your comments.
Regards!
There was a problem hiding this comment.
@jtimal i see this change is still present, can you undo it? thanks
There was a problem hiding this comment.
hi @atarix83 I have already undone the change
There was a problem hiding this comment.
@jtimal : The problem was that when you undid the change, the alignment in that file got accidentally messed up. I just fixed it by pushing a commit to your branch: 8c8df56
With that fix, the changes to breadcrumbs.component.spec.ts have been fully reverted, so that it no longer appears in the "Files changed" tab at the top of this PR.
There was a problem hiding this comment.
@tdonohue ok, thank you very much and an apology for this.
|
@atarix83 : I asked @jtimal to remove the tooltip from the final part of the breadcrumbs. It's not necessary to show the tooltip in that final part, as the full title is visible just below the breadcrumbs. In other words, tooltips should only be displayed for titles of parent objects in the breadcrumbs. This is similar to 6.x behavior, as on the Item page itself, 6.x never displayed the full title in the breadcrumbs. Instead it just displayed "View Item". In 7.x, we choose to display a snippet of the title...but there's no need to show the full title in the breadcrumbs. |
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Re-tested today. Thanks @jtimal ! This looks good to me now.
In today's meeting, @atarix83 and I briefly discussed this and agreed that the tooltip isn't necessary on the last part of the breadcrumb (the current page) as the title is always displayed in full on the current page.
Therefore, I'm going to go ahead and merge this immediately.
Thank you very much for all your help ! |
3 participants
Description
Small PR based in Angular Issue
Expected result:
