Skip to content

[CST-7693] Missing Translations added#1977

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
4Science:CST-7693
Dec 7, 2022
Merged

[CST-7693] Missing Translations added#1977
tdonohue merged 1 commit intoDSpace:mainfrom
4Science:CST-7693

Conversation

@corrad82-4s
Copy link
Copy Markdown
Contributor

@corrad82-4s corrad82-4s commented Nov 29, 2022

References

Add references/links to any related issues or PRs. These may include:

Description

Missing translations have been added, 'or' hard coded has been moved to i18n files.

List of changes in this PR:

  • Components having 'or' hard coded have been updated with usage of translations
  • missing translations added to i18n files

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Nov 29, 2022
@tdonohue tdonohue added this to the 7.5 milestone Nov 29, 2022
@tdonohue tdonohue self-requested a review December 1, 2022 15:42
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @corrad82-4s ! These look correct to me. Tested them quickly and they all appear to work.

@tdonohue tdonohue merged commit 2327901 into DSpace:main Dec 7, 2022
@abollini abollini deleted the CST-7693 branch February 19, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

No open projects
Status: ✅ Done

2 participants