Update to use GitHub CodeQL for code scanning (Angular UI)#1989
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Dec 6, 2022
Merged
Update to use GitHub CodeQL for code scanning (Angular UI)#1989tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue merged 1 commit intoDSpace:mainfrom
Conversation
tdonohue
force-pushed
the
enable_github_codeql
branch
from
480eada to
3f9884e
Compare
Member
Author
|
Merging to enable GitHub Code Scanning. The basics are all working. We can adapt as needed. (For about one week, LGTM will continue to function in order to allow us to see how Code Scanning works alongside LGTM) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of Code Scanning from DSpace/DSpace#8548 to Angular UI
Description
Enables GitHub Code Scanning via a new GitHub Action defined in
codescan.ymlThis will (eventually) replace our usage of LGTM.com, as LGTM is retiring later this year (after being integrated into GitHub). See https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/
Currently, Code Scanning is configured with default settings & enabled for all PRs and all commits to
main.It appears this PR has run it's own initial scan which can be found in the "Code scanning results" in the checks below. This can be used to review this PR is working, and it shows that we have some code cleanup/analysis to do. It is also possible some of these are false positives, as we occasionally hit those with LGTM (and this code scanner works similar to LGTM).