Skip to content

Ds1931 polish translation#2001

Merged
tdonohue merged 3 commits intoDSpace:mainfrom
michdyk:DS1931---Polish-Translation
Dec 21, 2022
Merged

Ds1931 polish translation#2001
tdonohue merged 3 commits intoDSpace:mainfrom
michdyk:DS1931---Polish-Translation

Conversation

@michdyk
Copy link
Copy Markdown
Contributor

@michdyk michdyk commented Dec 14, 2022

References

Add references/links to any related issues or PRs. These may include:
Fixes #1931

Description

Complete Polish translation #1931 donated by PCG Academia

Instructions for Reviewers

Users are now able to switch their UI language to Polish (Polski) by using an example config.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Full Polish translation
Enabling Polish language
@tdonohue tdonohue self-requested a review December 14, 2022 16:16
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Dec 14, 2022
@tdonohue tdonohue added this to the 7.5 milestone Dec 14, 2022
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michdyk : Thank you for this Polish translation! I gave it a test today and it works well. However, I noticed on the homepage that the term "DSpace CRIS" is used in a three places (I've noted them inline below). We need to change those to say "DSpace", as DSpace and DSpace CRIS are two different products. I can only accept contributions for DSpace, as the DSpace CRIS product is managed/controlled by 4Science.

Once these minor translation updates are made, this should be ready to merge. Thanks!

Comment thread src/assets/i18n/pl.json5 Outdated
Comment thread src/assets/i18n/pl.json5 Outdated
Comment thread src/assets/i18n/pl.json5 Outdated
Removing CRIS references
@michdyk
Copy link
Copy Markdown
Contributor Author

michdyk commented Dec 21, 2022

@tdonohue Sorry for that, we are working on both instances of DSpace and DSpace CRIS and probably some of the keys were copied by mistake. I removed CRIS references that you mentioned and rechecked the file. It looks good to me, so I requested an update.

@michdyk michdyk requested a review from tdonohue December 21, 2022 12:10
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @michdyk ! This looks great now. Merging immediately so that it can be included in 7.5 (due in Feb)

@tdonohue tdonohue merged commit bee32d6 into DSpace:main Dec 21, 2022
@michdyk
Copy link
Copy Markdown
Contributor Author

michdyk commented Dec 22, 2022

Great! Thanks @tdonohue for your help! I appreciate that! I am really excited that the translation will be available for public in 7.5. release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Complete Polish translation

2 participants