Skip to content

Enable / disable spellcheck for textarea inputs via config#2003

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
mark-cooper:textarea-spellcheck
Dec 20, 2022
Merged

Enable / disable spellcheck for textarea inputs via config#2003
tdonohue merged 1 commit intoDSpace:mainfrom
mark-cooper:textarea-spellcheck

Conversation

@mark-cooper
Copy link
Contributor

@mark-cooper mark-cooper commented Dec 16, 2022

References

Description

Currently, by default, dspace-angular generates textarea elements with spellcheck="false" attributes. This PR enables the spellcheck attribute value to be set via config. The default behavior has been updated to spellcheck="true" to match the DSpace v6 default behavior.

Instructions for Reviewers

Fire up the devserver and confirm that textarea form fields have the spellcheck="true" attribute value. Spellcheck behavior will depend on browser settings, but if spellchecking is not disabled spelling mistakes will be highlighted.

To verify the original behavior (spellcheck="false") set form.spellCheck: false in the config and repeat.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added this to the 7.5 milestone Dec 16, 2022
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Dec 16, 2022
@tdonohue tdonohue self-requested a review December 16, 2022 15:35
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @mark-cooper ! I verified this works as described. Spellcheck is on by default, but setting it to false turns off the spellcheck highlighting of my browser (Chrome).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge new feature

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Enable / disable textarea spellchecking via config

2 participants