Enable / disable spellcheck for textarea inputs via config#2003
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Dec 20, 2022
Merged
Enable / disable spellcheck for textarea inputs via config#2003tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue merged 1 commit intoDSpace:mainfrom
Conversation
tdonohue
approved these changes
Dec 20, 2022
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @mark-cooper ! I verified this works as described. Spellcheck is on by default, but setting it to false turns off the spellcheck highlighting of my browser (Chrome).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Currently, by default, dspace-angular generates textarea elements with spellcheck="false" attributes. This PR enables the spellcheck attribute value to be set via config. The default behavior has been updated to spellcheck="true" to match the DSpace v6 default behavior.
Instructions for Reviewers
Fire up the devserver and confirm that textarea form fields have the spellcheck="true" attribute value. Spellcheck behavior will depend on browser settings, but if spellchecking is not disabled spelling mistakes will be highlighted.
To verify the original behavior (spellcheck="false") set
form.spellCheck: falsein the config and repeat.Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.