Skip to content

Group description edit#2013

Merged
tdonohue merged 2 commits intoDSpace:mainfrom
4Science:CST-7694
Jan 18, 2023
Merged

Group description edit#2013
tdonohue merged 2 commits intoDSpace:mainfrom
4Science:CST-7694

Conversation

@corrad82-4s
Copy link
Copy Markdown
Contributor

@corrad82-4s corrad82-4s commented Dec 23, 2022

References

Add references/links to any related issues or PRs. These may include:

Description

Short summary of changes (1-2 sentences).
Replaced replace operation with add in group-form component and added tests on edit of group description.

Instructions for Reviewers

List of changes in this PR:

  • Replaced replace operation with add in group-form component

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

  • Login as admin
  • Navigate to the edit of a non permanent group
  • Edit the description & save, or add a new description if missing

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge labels Jan 5, 2023
@tdonohue tdonohue self-requested a review January 5, 2023 15:34
@tdonohue tdonohue added this to the 7.5 milestone Jan 5, 2023
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @corrad82-4s ! Tested this today and it fixes the bug. Code looks good too.

@tdonohue tdonohue merged commit 112e93e into DSpace:main Jan 18, 2023
@abollini abollini deleted the CST-7694 branch February 19, 2023 16:51
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Jul 29, 2024
Task/dspace cris 2023 02 x/DSC-1841

Approved-by: Andrea Barbasso
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Cannot edit group description from the UI

3 participants