Buttons have same name but different actions.#2092
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Mar 1, 2023
Merged
Conversation
tdonohue
approved these changes
Feb 28, 2023
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Overall this looks good @CrisGuzmanS ! Thanks. However, I have one minor change which I'd like to be made before we merge this PR. The text that you changed needs a minor modification (see inline below).
Member
|
Thanks @CrisGuzmanS ! This looks good to me now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Hello @tdonohue i have already with the 3rd task for this issue. I will be attentive to any comments.
Description
I added an
aria-labelfor edit, delete and view buttons in my dspace section.Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
aria-labeladded in edit, view and delete button inside ofworkspaceitem-actions.component.htmlfile.submission.workflow.generic.delete-helpin en.json5Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.