Skip to content

Buttons have same name but different actions.#2092

Merged
tdonohue merged 2 commits intoDSpace:mainfrom
CrisGuzmanS:issues/1186-470750
Mar 1, 2023
Merged

Buttons have same name but different actions.#2092
tdonohue merged 2 commits intoDSpace:mainfrom
CrisGuzmanS:issues/1186-470750

Conversation

@CrisGuzmanS
Copy link
Copy Markdown
Contributor

@CrisGuzmanS CrisGuzmanS commented Feb 14, 2023

References

Hello @tdonohue i have already with the 3rd task for this issue. I will be attentive to any comments.

Description

I added an aria-label for edit, delete and view buttons in my dspace section.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • aria-label added in edit, view and delete button inside of workspaceitem-actions.component.html file.
  • i chanfed the text for: submission.workflow.generic.delete-help in en.json5
  1. login as administrator.
  2. go to my dspace section
  3. open the browser console. You will see that the three buttons has aria-label according to the tooltip.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug accessibility 1 APPROVAL pull request only requires a single approval to merge labels Feb 14, 2023
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Overall this looks good @CrisGuzmanS ! Thanks. However, I have one minor change which I'd like to be made before we merge this PR. The text that you changed needs a minor modification (see inline below).

Comment thread src/assets/i18n/en.json5 Outdated
@tdonohue tdonohue added this to the 7.6 milestone Mar 1, 2023
@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented Mar 1, 2023

Thanks @CrisGuzmanS ! This looks good to me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge accessibility bug

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[Deque Analysis] MyDSpace page's "serious" accessibility issues

2 participants