avoiding error when user unselect a filter option#2113
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Feb 27, 2023
Merged
Conversation
tdonohue
approved these changes
Feb 27, 2023
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @CrisGuzmanS ! This fix works for me. The code looks good to
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Aug 16, 2024
[DSC-1874] Improve related-items popover open/close behaviour Approved-by: Stefano Maffei
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @tdonohue i have good news. I've fixed Removing a filter generates an invalid query. I will be attentive to any comments. 😄
References
Description
When user unselect a filter tag option, the query is executed succesfully.
Instructions for Reviewers
List of changes in this PR:
search-labelscomponent tosearch-label.Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.