Skip to content

avoiding error when user unselect a filter option#2113

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
CrisGuzmanS:issues/1998
Feb 27, 2023
Merged

avoiding error when user unselect a filter option#2113
tdonohue merged 1 commit intoDSpace:mainfrom
CrisGuzmanS:issues/1998

Conversation

@CrisGuzmanS
Copy link
Copy Markdown
Contributor

@CrisGuzmanS CrisGuzmanS commented Feb 21, 2023

Hello @tdonohue i have good news. I've fixed Removing a filter generates an invalid query. I will be attentive to any comments. 😄

References

Description

When user unselect a filter tag option, the query is executed succesfully.

Instructions for Reviewers

List of changes in this PR:

  • i moved stripOperatorFromFilterValue from search-labels component to search-label.
  1. go to search section.
  2. apply two subject queries.
  3. unselect any of them
  4. you will see that the query is executed succesfully

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge labels Feb 22, 2023
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @CrisGuzmanS ! This fix works for me. The code looks good to

@tdonohue tdonohue merged commit 07ee16a into DSpace:main Feb 27, 2023
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Aug 16, 2024
[DSC-1874] Improve related-items popover open/close behaviour

Approved-by: Stefano Maffei
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Removing a filter generates an invalid query

2 participants