EPerson creation page changed

[amanbudgujar]

References

• Fixes When creating a new EPerson "Reset password" button is not needed #2026

Description

While creating a new EPerson -

• Reset password button is not displayed.
• Submit button label changed from 'Save' to 'Create'.

Instructions for Reviewers

Steps to test

• Open page to add new eperson.
• Check that submit button label is changed from 'Save' to 'Create' and Reset Password button is not displayed.

List of changes in this PR:

• New variable added in en.json5 file.
• if statement added to display 'Reset Password' button in eperson-form.component.html file
• if eperson is non-null (i.e edit eperson mode), submit button label set to 'Save' and Reset Password button to be displayed in eperson-form.component.ts file.

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

@amanbudgujar : Just wanted to let you know this PR is failing a "lint" check cause of trailing spaces. You can find the details of the error by running yarn lint locally.

[amanbudgujar]

@tdonohue
Sorry about that.
I have pushed the updated code after testing it.
Please check if this can be reviewed now.

[amanbudgujar]

@tdonohue
Any update on this.

[tdonohue]

@amanbudgujar : This PR is on our 7.6 board and is waiting on reviewers to be assigned. As all reviewers are volunteers, we unfortunately cannot promise a timeline for when the review will occur. But, we can promise this fix will be reviewed in time for 7.6. Since it's a small PR though, hopefully we can find someone sooner rather than later (or maybe I'll find time to review it myself).

If you'd like to help our review process along, we accept PR feedback from anyone. So, you are welcome to help by volunteering to review or simply test (if you don't feel comfortable with code reviews yet) the PRs of others. That can help us keep our backlog smaller and allow us to get to your PRs more quickly as well. Thanks and hopefully I or someone else will get back to this PR soon.

[tdonohue]

👍 Thanks @amanbudgujar ! I finally got around to reviewing/testing this today. It works well, and I like that the creation page now has a "Create" button instead of a "Save" button.