Skip to content

browse-by-metadata-page works correctly on numeric 'value' param#2139

Merged
tdonohue merged 6 commits intoDSpace:mainfrom
CrisGuzmanS:issues/2128
Mar 23, 2023
Merged

browse-by-metadata-page works correctly on numeric 'value' param#2139
tdonohue merged 6 commits intoDSpace:mainfrom
CrisGuzmanS:issues/2128

Conversation

@CrisGuzmanS
Copy link
Copy Markdown
Contributor

Hello @tdonohue ✋. i already finished this issue. I will be attentive to any comments.

References

Add references/links to any related issues or PRs. These may include:

Description

Browse By Metadata page will work correctly on numeric 'value' param.

Instructions for Reviewers

i just avoid the symbol "+" in "+startsWith" to prevent conversion from string to number.

  1. login
  2. select any section from "all of DSpace" that its index is according to a metadata value.
  3. Search for an item that has leading "0". (like in the issue)
  4. you should be able to find the item.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR fixes an issue ticket, I've linked them together.

@CrisGuzmanS
Copy link
Copy Markdown
Contributor Author

Tim, i need to fix lint issues before

@tdonohue tdonohue added bug component: Discovery related to discovery search or browse system 1 APPROVAL pull request only requires a single approval to merge labels Mar 9, 2023
@tdonohue tdonohue added this to the 7.6 milestone Mar 9, 2023
Comment thread src/app/browse-by/browse-by-metadata-page/browse-by-metadata-page.component.ts Outdated
@tdonohue
Copy link
Copy Markdown
Member

@CrisGuzmanS : This now has some minor lint errors (cause of trailing spaces). If you run yarn lint locally you should be able to find them...or look at the "Files changed" tab in this PR for where they appear.

@CrisGuzmanS
Copy link
Copy Markdown
Contributor Author

I already fixed them @tdonohue 👍 my apologies.

Copy link
Copy Markdown
Member

@artlowel artlowel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CrisGuzmanS!

@tdonohue tdonohue merged commit 80c3416 into DSpace:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: Discovery related to discovery search or browse system

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

browse-by-metadata-page does not work correctly on numeric "value" param

3 participants