Skip to content

Fix #1702 - Move item collection with inheritPolicies support#2146

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
amgciadev:fix-1702-b
Apr 14, 2023
Merged

Fix #1702 - Move item collection with inheritPolicies support#2146
tdonohue merged 1 commit intoDSpace:mainfrom
amgciadev:fix-1702-b

Conversation

@amgciadev
Copy link
Copy Markdown
Contributor

@amgciadev amgciadev commented Mar 13, 2023

References

Add references/links to any related issues or PRs. These may include:

Description

Fixes an issue where the inheritPolicies parameter is not being sent when users request to move item collection and select the box "Inherit policies" when in the Move collection page

Instructions for Reviewers

List of changes in this PR:

  • Add inheritPolicies flag to moveCollection method in item-move.component.ts
  • Updated relevant test classes to account for new parameter

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge labels Mar 15, 2023
@tdonohue tdonohue added this to the 7.6 milestone Mar 15, 2023
@tdonohue tdonohue self-requested a review April 6, 2023 14:40
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @amgciadev ! I've tested this today (along with the backend PR: DSpace/DSpace#8717) and verified that the "Inherit policies" checkbox on the Move Item page now works properly. Code also looks good

@tdonohue tdonohue merged commit 3fcb113 into DSpace:main Apr 14, 2023
@amgciadev amgciadev deleted the fix-1702-b branch April 14, 2023 20:00
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Aug 23, 2024
Fix Cache issues when editing an item

Approved-by: Andrea Barbasso
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Move item to a different collection is not inheriting policies

2 participants