Fix Docker solr configset directories#2190
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Apr 13, 2023
Merged
Conversation
Member
Author
|
Merging immediately as this is obviously broken. |
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Sep 18, 2024
[DSC-1900] Approved-by: Francesco Molinaro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This issue was discovered by Andrés Sendra in Slack.
The configset directories in the
docker-compose-rest.ymlare incorrect after DSpace/DSpace#8679 was merged. They need to be the same as the configset directories defined in the backend's Docker scripts here: https://github.com/DSpace/DSpace/blob/main/docker-compose.yml#L110-L117This PR is a follow-up to #2189 which simply removes the "/dspace" subdirectory which no longer exists under the "/configsets" folder.