Skip to content

Add missing export for ItemRequest module#2194

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue:fix_item_request
Apr 19, 2023
Merged

Add missing export for ItemRequest module#2194
tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue:fix_item_request

Conversation

@tdonohue
Copy link
Copy Markdown
Member

@tdonohue tdonohue commented Apr 18, 2023

References

Fixes #2195

Description

Somewhere along the way the ItemRequest module is no longer being exported. This results in a blank page in the UI whenever you visit an ItemRequest page:
http://localhost:4000/request-a-copy/[token]

Instructions for Reviewers

  • Create a request for copy
    • Restrict a bitstream
    • Login as a user without privileges and submit a request for copy.
  • As a user who can respond to the request, login and visit http://localhost:4000/request-a-copy/[token]
    • Verify on main that you see a blank page.
    • Verify that with this PR, the request a copy page loads & you can then either approve or reject the request.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge labels Apr 18, 2023
@tdonohue tdonohue added this to the 7.6 milestone Apr 18, 2023
@tdonohue tdonohue self-assigned this Apr 18, 2023
@tdonohue
Copy link
Copy Markdown
Member Author

This fix was recommended by Nicolas Boulay on Slack. I was able to reproduce the issue & verify the fix.

Copy link
Copy Markdown
Contributor

@aroman-arvo aroman-arvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and OK

@tdonohue
Copy link
Copy Markdown
Member Author

Thanks @aroman-arvo for testing on your end! Merging this as that's two people who have verified the fix.

@tdonohue tdonohue merged commit ade9533 into DSpace:main Apr 19, 2023
@tdonohue tdonohue deleted the fix_item_request branch April 19, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Request item stop working

2 participants