Fix #2197 authority key lookup#2198
Merged
tdonohue merged 2 commits intoDSpace:mainfrom May 16, 2023
Merged
Conversation
Avoid an authority key lookup when it starts with "will be generated::"
tdonohue
approved these changes
May 16, 2023
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @uofmsean ! Verified this fixes the reported bug when ORCID Authority is enabled https://wiki.lyrasis.org/display/DSDOC7x/ORCID+Authority Submission form appears to work properly now and no errors on backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid an authority key lookup in DsDynamicVocabularyComponent when it starts with "will be generated::"
References
Fixes #2197
Description
During initialization for DsDynamicVocabularyComponent, avoid an authority key lookup when it starts with "will be generated::".
Instructions for Reviewers
List of changes in this PR:
When ORCID authority is enabled, you can now lookup an author, save the submission for later, and when you reopen the submission, the correct author value (last name and first name) should be shown, and there will no longer be a Solr exception with the "will be generated::" lookup. Note that a complete fix for the Solr lookup exceptions requires DSpace/DSpace#8490 to be resolved as well.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.