Skip to content

Fixes #8384: Added Curate tab in Edit Item page#2211

Merged
tdonohue merged 3 commits intoDSpace:mainfrom
enea4science:feature/8384-edit-item-curate
May 8, 2023
Merged

Fixes #8384: Added Curate tab in Edit Item page#2211
tdonohue merged 3 commits intoDSpace:mainfrom
enea4science:feature/8384-edit-item-curate

Conversation

@enea4science
Copy link
Copy Markdown
Contributor

@enea4science enea4science commented Apr 26, 2023

References

Description

Added Curate tab in Edit Item page

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

Comment thread src/app/item-page/edit-item-page/item-curate/item-curate.component.spec.ts Outdated
@tdonohue tdonohue added bug tools: curation-tasks 1 APPROVAL pull request only requires a single approval to merge labels Apr 26, 2023
@tdonohue tdonohue added this to the 7.6 milestone Apr 26, 2023
@tdonohue tdonohue self-requested a review April 27, 2023 15:03
@hardyoyo hardyoyo self-requested a review April 27, 2023 15:04
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enea4science : Thanks for this PR! Overall, it works well. However, I found that the curation task dropdown does NOT load quickly the first time you access this Curate Tab. When I first visit the Item Curate tab, and try to open the dropdown I see this:
empty-dropdown

If I wait for 5-10 seconds, the dropdown eventually populates and everything works. However, I do not see this same behavior on the Community or Collection "Curate" tab... it seems to be a bug specific to this new Item "Curate" tab.

Here's how I've been able to reproduce the problem I'm seeing:

  1. First, install this PR and start up the UI in production mode (yarn build:prod; yarn serve:ssr)
  2. Login as an Admin
  3. Immediately browse to an Item, click Edit and click on the Curate tab
  4. Try to immediately open the dropdown. It will be empty.
  5. After it loads, everything will work fine. Visiting another Item's Curate tab will also work fine. The empty dropdown only appears the first time you access the Item Curate tab after logging in.

As I said, I cannot reproduce the same behavior on the Community or Collection Curate tab. While this isn't a severe bug, it's a bit annoying. So, it'd be nice if we can find a way to solve it in this PR.

@enea4science
Copy link
Copy Markdown
Contributor Author

Hello @tdonohue
The issue is now fixed.

@tdonohue tdonohue self-requested a review May 8, 2023 14:01
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @enea4science ! The prior bug has now been fixed. This PR works properly now & I can successfully start curation tasks from the Edit Item -> Curate tab. Code looks good too!

@tdonohue tdonohue merged commit c233927 into DSpace:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug tools: curation-tasks

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

DSpace 7 Edit Item doesn't support Curation Tasks (like DSpace 6)

2 participants