Skip to content

Enable line breaks in deposit license during submission.#2229

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
mwoodiupui:license-linebreaks
May 11, 2023
Merged

Enable line breaks in deposit license during submission.#2229
tdonohue merged 1 commit intoDSpace:mainfrom
mwoodiupui:license-linebreaks

Conversation

@mwoodiupui
Copy link
Copy Markdown
Member

@mwoodiupui mwoodiupui commented May 3, 2023

Description

The submission page packs the deposit license into a rectangle regardless of whitespace in the original. This patch preserves whitespace in the license text.

Instructions for Reviewers

List of changes in this PR:

  • preserve-line-breaks class added to the license text element.

To test: write a default license with line breaks in it and see if they show up when you start a submission.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@mwoodiupui mwoodiupui self-assigned this May 3, 2023
@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge labels May 3, 2023
@tdonohue tdonohue added this to the 7.6 milestone May 3, 2023
@tdonohue tdonohue requested a review from artlowel May 4, 2023 14:37
Copy link
Copy Markdown
Member

@artlowel artlowel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mwoodiupui!

@tdonohue tdonohue merged commit 84d8a61 into DSpace:main May 11, 2023
@mwoodiupui mwoodiupui deleted the license-linebreaks branch June 8, 2023 16:49
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Sep 10, 2024
Task/dspace cris 2023 02 x/DSC-1904

Approved-by: Vincenzo Mecca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: submission

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants