Skip to content

Fixed community's sub-communities and collections sort#2239

Merged
tdonohue merged 2 commits intoDSpace:mainfrom
alexandrevryghem:fix-community-page-sorting_contribute-main
May 12, 2023
Merged

Fixed community's sub-communities and collections sort#2239
tdonohue merged 2 commits intoDSpace:mainfrom
alexandrevryghem:fix-community-page-sorting_contribute-main

Conversation

@alexandrevryghem
Copy link
Copy Markdown
Member

References

Description

Fixed community's sub-communities and collections sort options from url being ignored when making the request to the backend (meaning that after refreshing the page your sort options would be lost). The pagination options for sub-communities were also lost after refreshing the page.

Instructions for Reviewers

List of changes in this PR:

  • Made changes to the CommunityPageSubCollectionListComponent & CommunityPageSubCommunityListComponent to retrieve the pagination options and the sort options from the url when available.

Guidance for how to test this PR:

  • After testing the backend PR you should have a community containing at least 2 sub-communities and 2 collections with different names and go to the parent community page
  • Click on the gear next to the collections and to the sub-communities and select Descending
  • Check that the collections and the sub-communities are sorted in descending order
  • Check that after refreshing the page the collections and the sub-communities are still sorted in descending order
  • Click on the gear next to the collections and to the sub-communities and select Ascending
  • Check that the collections and the sub-communities are sorted in ascending order
  • Check that after refreshing the page the collections and the sub-communities are still sorted in ascending order
  • Set the page size for the sub-communities to 1
  • Check that after refreshing the page the page size is still 1

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem self-assigned this May 10, 2023
@alexandrevryghem alexandrevryghem added bug usability 1 APPROVAL pull request only requires a single approval to merge medium priority component: Community Community display or editing labels May 10, 2023
@alexandrevryghem alexandrevryghem added this to the 7.6 milestone May 10, 2023
@tdonohue tdonohue self-requested a review May 11, 2023 14:45
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alexandrevryghem ! As noted in the backend PR review, tested this today and everything is working. Code looks good too.

@tdonohue tdonohue merged commit d7372bc into DSpace:main May 12, 2023
milanmajchrak pushed a commit to dataquest-dev/dspace-angular that referenced this pull request Mar 22, 2024
…ge-sorting_contribute-main

Fixed community's sub-communities and collections sort
milanmajchrak added a commit to dataquest-dev/dspace-angular that referenced this pull request Mar 22, 2024
…rting) (#547)

* Merge pull request DSpace#2187 from mspalti/shibboleth-refresh

Shibboleth page update after authentication

* Merge pull request DSpace#2239 from alexandrevryghem/fix-community-page-sorting_contribute-main

Fixed community's sub-communities and collections sort

---------

Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: Community Community display or editing medium priority usability

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

DESC sort not working in list of sub-communities/sub-collections

2 participants