Fixed community's sub-communities and collections sort#2239
Merged
tdonohue merged 2 commits intoDSpace:mainfrom May 12, 2023
Merged
Conversation
…sorting_contribute-main
8 tasks
tdonohue
approved these changes
May 12, 2023
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! As noted in the backend PR review, tested this today and everything is working. Code looks good too.
milanmajchrak
pushed a commit
to dataquest-dev/dspace-angular
that referenced
this pull request
Mar 22, 2024
…ge-sorting_contribute-main Fixed community's sub-communities and collections sort
milanmajchrak
added a commit
to dataquest-dev/dspace-angular
that referenced
this pull request
Mar 22, 2024
…rting) (#547) * Merge pull request DSpace#2187 from mspalti/shibboleth-refresh Shibboleth page update after authentication * Merge pull request DSpace#2239 from alexandrevryghem/fix-community-page-sorting_contribute-main Fixed community's sub-communities and collections sort --------- Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Fixed community's sub-communities and collections sort options from url being ignored when making the request to the backend (meaning that after refreshing the page your sort options would be lost). The pagination options for sub-communities were also lost after refreshing the page.
Instructions for Reviewers
List of changes in this PR:
CommunityPageSubCollectionListComponent&CommunityPageSubCommunityListComponentto retrieve the pagination options and the sort options from the url when available.Guidance for how to test this PR:
DescendingAscendingChecklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.