Skip to content

[DURACOM-99] Tests fixed#2249

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
4Science:DURACOM-99
May 15, 2023
Merged

[DURACOM-99] Tests fixed#2249
tdonohue merged 1 commit intoDSpace:mainfrom
4Science:DURACOM-99

Conversation

@davide-negretti
Copy link
Copy Markdown
Contributor

@davide-negretti davide-negretti commented May 12, 2023

References

Description

  • Unit test were failing on machines with it locale

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@davide-negretti davide-negretti mentioned this pull request May 12, 2023
6 tasks
@davide-negretti davide-negretti requested a review from tdonohue May 12, 2023 21:50
@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge testing framework Related specifically to Unit or Integration (e2e) Tests labels May 15, 2023
@tdonohue tdonohue added this to the 7.6 milestone May 15, 2023
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @davide-negretti ! This looks good and makes sense to me. I see the tests pass in GitHub CI too, so merging immediately

@tdonohue tdonohue merged commit b93e0bf into DSpace:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug testing framework Related specifically to Unit or Integration (e2e) Tests

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Italian translation - i18n language files

2 participants