Fix test#2256
Merged
tdonohue merged 3 commits intoDSpace:mainfrom May 19, 2023
Merged
Conversation
tdonohue
requested changes
May 18, 2023
Member
tdonohue
left a comment
There was a problem hiding this comment.
@atarix83 : Unfortunately, this fix didn't resolve the issues with the broken tests. Therefore, I've applied a "quick fix" in #2257 which relies on commenting out the problematic test in this workspaceitems-delete-page.component.spec.ts.
I've also created a follow-up ticket in #2258 which I assigned to you. If you or @alisaismailati (or someone else on your team) could take a look at how to fix the problematic test, I'd appreciate it!
main is working again for now by simply commenting out the problematic test in 12a561d
Contributor
Author
|
should be fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix issue with failing test on main branch
Fixes #2258
Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.