Skip to content

Fix test#2256

Merged
tdonohue merged 3 commits intoDSpace:mainfrom
4Science:fix_WorkspaceitemsDeletePageComponent_test
May 19, 2023
Merged

Fix test#2256
tdonohue merged 3 commits intoDSpace:mainfrom
4Science:fix_WorkspaceitemsDeletePageComponent_test

Conversation

@atarix83
Copy link
Copy Markdown
Contributor

@atarix83 atarix83 commented May 18, 2023

Description

Fix issue with failing test on main branch
Fixes #2258

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue self-requested a review May 18, 2023 17:06
@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge testing framework Related specifically to Unit or Integration (e2e) Tests labels May 18, 2023
@tdonohue tdonohue added this to the 7.6 milestone May 18, 2023
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atarix83 : Unfortunately, this fix didn't resolve the issues with the broken tests. Therefore, I've applied a "quick fix" in #2257 which relies on commenting out the problematic test in this workspaceitems-delete-page.component.spec.ts.

I've also created a follow-up ticket in #2258 which I assigned to you. If you or @alisaismailati (or someone else on your team) could take a look at how to fix the problematic test, I'd appreciate it!

main is working again for now by simply commenting out the problematic test in 12a561d

@atarix83
Copy link
Copy Markdown
Contributor Author

@tdonohue

should be fixed now

@tdonohue tdonohue self-requested a review May 18, 2023 21:36
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you @atarix83 for the quick fix. Looks good and passes CI

@tdonohue tdonohue merged commit e04dd9e into DSpace:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge testing framework Related specifically to Unit or Integration (e2e) Tests

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Fix problematic test in workspaceitems-delete-page.component.spec.ts

2 participants