new project metadata representation component

[paulo-graca]

References

Add references/links to any related issues or PRs. These may include:

• Fixes Missing Project metadata representation component #2276

Description

This PR adds a new component to address issue #2276.

Instructions for Reviewers

You will find that when trying to create a relationship from a Project to a Publication, the project label is shown on the submission form (the dc:title field)

[artlowel]

@paulo-graca The code looks sensible, but I don't seem to be able to reproduce the issue in the first place. If I create a relationship to a Project in the submission it already has a proper name:

            <row>
                <relation-field>
                    <relationship-type>isProjectOfPublication</relationship-type>
                    <search-configuration>project</search-configuration>
                    <label>Project</label>
                    <hint>import a project</hint>
                </relation-field>
            </row>

Perhaps you can send me the exact submission config I need to reproduce the issue?

[paulo-graca]

Thank you @artlowel for your feedback. I will try to gather more data.

[paulo-graca]

@artlowel I'm using openAIREPublicationSubmission

With the field specification:

            <row>
                <relation-field>
                    <relationship-type>isProjectOfPublication</relationship-type>
                    <search-configuration>project</search-configuration>
                    <repeatable>true</repeatable>
                    <name-variants>false</name-variants>
                    <label>Funding</label>
                    <hint>Add a related Funding</hint>
                    <linked-metadata-field>
                        <dc-schema>dc</dc-schema>
                        <dc-element>relation</dc-element>
                        <input-type>onebox</input-type>
                    </linked-metadata-field>
                    <externalsources>openAIREFunding</externalsources>
                    <required></required>
                </relation-field>
            </row>

and the relationship type definition has the following:

	<type>
		<leftType>Publication</leftType>
		<rightType>Project</rightType>
		<leftwardType>isProjectOfPublication</leftwardType>
		<rightwardType>isPublicationOfProject</rightwardType>
		<leftCardinality>
			<min>0</min>
		</leftCardinality>
		<rightCardinality>
			<min>0</min>
		</rightCardinality>
	</type>

This is what is happening:

[artlowel]

Thanks @paulo-graca!

The key was to use the openaire4 virtual metadata mapping. If I use that, I can reproduce the issue.

However your fix doesn't work for me in all cases, because you've created a new component with a decorator specific to dspace (i.e. @metadataRepresentationComponent). You need to add that component to the ENTRY_COMPONENTS array of its module. That way angular will know it exists and process that decorator when the app starts. Otherwise you just have to be lucky that it's already been processed by the time you need it

[paulo-graca]

Thank you @artlowel for your feedback, I will address it soon as possible!

[paulo-graca]

@artlowel I've just addressed your feedback. It's working for me.

I will just address the remaining styling issues.

[artlowel]

Thanks @paulo-graca!

The changes look good, but the tests fail at the moment.

Looks like you still need to provide DSONameService in project-item-metadata-list-element.component.spec.ts

Meaning, add something like this to the beforeEach:

dsoNameService = jasmine.createSpyObj({
  getName: projectTitle
});

And then add that mock service to the providers list of the testbed:

declarations: [ProjectItemMetadataListElementComponent],
providers: [
  { provide: DSONameService, useValue: dsoNameService }
],
schemas: [NO_ERRORS_SCHEMA]

Once the tests are fixed, I'm a +1 for this PR

[paulo-graca]

I don't have a test system setup on my remote host, I was trying to do that. But it will take me some time.
I didn't saw your feedback in time before my last push, but I think I was in the right track. Thank you! I will try to address it.