DS-8651-8879: "Browse by" incorrect usage of _links sent from server

[buithaihai]

References

• Requires "Browse By" fixes DSpace#8871

Description

Accompanied with with DSpace/DSpace#8871, this PR fix DSpace/DSpace#8651 and DSpace/DSpace#8879

Details

Instructions for Reviewers

List of changes in this PR:

1. For Browse pages don't take into account sort configuration DSpace#8651: Updated browse-by-date-page.component.ts to set currentSort.direction with direction value from server and use them for subsequent requests
2. /browses endpoints return invalid _links based on the browseType value. DSpace#8879: Updated browse-response-parsing.service.ts to make use of new attribute _links.items_fieldValueOnly in order to ensure that any ValueListBrowseDefinition only request "/items" endpoint when there is a valid "filterValue" present.

Testing

After setting up DSpace server as in DSpace/DSpace#8871, go to angular page and:

1. Go to "/browse/dateissued" and verify that the results are sorted in descending order
2. Navigate to "/browse/author" ( All of DSpace -> By Author) and verify that there are no 500 requests for "/items" endpoints and no console errors logged
3. Navigate to "/browse/title" ( All of DSpace -> By Title) and verify that there are no console errors logged

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[alanorth]

Does this require the as-of-yet unmerged DSpace/DSpace#8871? I am seeing the HTTP 500 error that @tdonohue mentioned elsewhere, and the browse by pages don't work:

[buithaihai]

Yes, it is required, as stated.

[alanorth]

@buithaihai sorry, I didn't understand from your description that it was mandatory. Also, the linked pull request has feedback requested so I wasn't sure if it was in a working state. Apologies that I didn't get to test this for 7.6. I can try to test it for 7.6.1 though!

[buithaihai]

@alanorth No problem, it was already not ready for 7.6 anyways. Just take your time.

[github-actions]

Hi @buithaihai,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[github-actions]

This pull request has been automatically marked as stale because it has not had
activity in one year. It will be closed in 14 days if no further activity occurs.

Allowing pull requests to close as stale helps us filter out old work that is no longer
relevant and helps developers focus on reviewing current work.

All pull requests closed by this bot act like normal pull requests;
they can be searched for, commented on or reopened at any point.

If these changes are still relevant then please comment and/or rebase your PR based on the
latest DSpace code. This will remove the stale status and notify us to assign a reviewer
for your PR.

[github-actions]

This pull request has been closed automatically. If these changes are still relevant
then please re-open this pull request with a comment and rebase your PR based on the latest
DSpace code. This will notify us to assign a reviewer to your PR.