"Add Collection" form loads#2332
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Jun 22, 2023
Merged
Conversation
tdonohue
approved these changes
Jun 22, 2023
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alisaismailati ! This looks good to me & it works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
ngOnInit()is implemented forcollection-form.component.ts.Instructions for Reviewers
List of changes in this PR:
ngOnInit()is implemented forsrc/app/collection-page/collection-form/collection-form.component.ts. When a collection is edited,ngOnChangesis called beforengOnInit, so onngOnInitwe need to check if theformModelis already initialized and if it is not, we need to initialize it. We also need to check thedsoto be different from null in order to initialize the form.Include guidance for how to test or review your PR.
Steps to reproduce a bug are the same as mentioned in #2329.
Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.