Added support to import from external source on Edit Item > Relationships

[alexandrevryghem]

References

• Fixes Import from external source on edit item > relationships #2353

Description

The lookup in external sources is not available in Edit Item > Relationships. We can only add internal DSpace entities there as a linked item, now we will also be able to import a new item from an external source there.

Instructions for Reviewers

List of changes in this PR:

• DsDynamicLookupRelationModalComponent: List all the external sources which are enabled/configured in the popup modal

Guidance for how to test and review this PR:

• Initialise the entities with initialize-entities -f dspace/config/entities/relationship-types.xml
• Create 2 collections, one with entity type Publication and one with Person
• In item-submission.xml use those 2 collection handles to link to their respective submission-names: Publication & Person
• Add orcid.api-url = https://pub.sandbox.orcid.org/v3.0 to you local.cfg, because ORCID uses the api which requires credentials by default instead of the public one (see ORCID search should work out of the box DSpace#8836 for more info about that issue/workaround)
• Check that you can still import person in the publication form using ORCID
• Check that you can now also import persons in the Edit Item > Relationships tab using ORCID and that a non imported person is created automatically

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

@alexandrevryghem : Thanks! Overall, this works, so I'll go ahead and approve it. However, with this new feature I've noticed a lot of missing i18n keys. For instance, when adding a Publication relation (by Editing a Person) you see this:

Here's the ones I've found that need to be added (so far) & my best guess as what each should say:

"submission.sections.describe.relationship-lookup.search-tab.tab-title.orcidWorks" = "ORCID ({{ count }})",
"submission.sections.describe.relationship-lookup.search-tab.tab-title.crossref" = "CrossRef ({{ count }})",
"submission.sections.describe.relationship-lookup.search-tab.tab-title.scopus" = "Scopus ({{ count }})",
"submission.sections.describe.relationship-lookup.search-tab.tab-title.openaireFunding" = "Funding OpenAIRE ({{ count }})",
"submission.sections.describe.relationship-lookup.search-tab.tab-title.sherpaJournalIssn" = "Sherpa Journals by ISSN ({{ count }})",
"submission.sections.describe.relationship-lookup.title.Journal" = "Journal",
"journalvolume.search.results.head" = "Journal Volume Search Results",
"journalissue.search.results.head" = "Journal Issue Search Results",
"relationships.isVolumeOf.JournalVolume" = "Journal Volume",
"relationships.isIssueOf.JournalIssue = "Journal Issue",
"relationships.isJournalVolumeOf" = "Journal Volume",

If you'd be willing to add these i18n keys as part of this PR, I think it'd be beneficial to this new feature.

[kshepherd]

+1, I have also tested and it works well.
FWIW I didn't see the i18n labels that @tdonohue mentioned - as indicated, they look like external sources other than ORCID person that need a key for this modal, so they won't show up if not configured.

[tdonohue]

👍 Thanks @alexandrevryghem ! Retested and the i18n keys are now showing properly. Merging as this is at +2