Replace all old docker "dspace-7_x" tags with "latest" on main#2394
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Jul 24, 2023
Merged
Replace all old docker "dspace-7_x" tags with "latest" on main#2394tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue merged 1 commit intoDSpace:mainfrom
Conversation
Member
Author
|
Merging immediately as this is required for Docker to continue to work proper on |
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Oct 22, 2024
…Space#2394) [DSC-1864] Merge tag 'dspace-7.6.2' into task/dspace-cris-2023_02_x/DSC-1864_re-worked Approved-by: Andrea Barbasso
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Currently, our Docker scripts on
mainare still referencing thedspace-7_xtagged Docker images. However in #2359, we updatedmainbranch to generate Docker images with thelatesttag. (Thedspace-7_xtag in DockerHub is to be used for thedspace-7_xbranch in GitHub.)In other words:
mainbranch in GitHub should always uselatesttag in DockerHubdspace-7_xbranch in GitHub should always usedspace-7_xtag in DockerHubThis PR ensures that our Docker scripts on
mainare always referencing the taglatestfrom DockerHub. (This ensures thatmainisn't accidentally using Docker images from ourdspace-7_xbrach)(Corresponding PR was submitted to backend as well: DSpace/DSpace#8974)
Instructions for Reviewers
mainnow uselatestimages from DockerHub.