Skip to content

Replace all old docker "dspace-7_x" tags with "latest" on main#2394

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue:docker_version_fixes
Jul 24, 2023
Merged

Replace all old docker "dspace-7_x" tags with "latest" on main#2394
tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue:docker_version_fixes

Conversation

@tdonohue
Copy link
Copy Markdown
Member

@tdonohue tdonohue commented Jul 24, 2023

References

Description

Currently, our Docker scripts on main are still referencing the dspace-7_x tagged Docker images. However in #2359, we updated main branch to generate Docker images with the latest tag. (The dspace-7_x tag in DockerHub is to be used for the dspace-7_x branch in GitHub.)

In other words:

  • main branch in GitHub should always use latest tag in DockerHub
  • dspace-7_x branch in GitHub should always use dspace-7_x tag in DockerHub

This PR ensures that our Docker scripts on main are always referencing the tag latest from DockerHub. (This ensures that main isn't accidentally using Docker images from our dspace-7_x brach)

(Corresponding PR was submitted to backend as well: DSpace/DSpace#8974)

Instructions for Reviewers

  • Assuming Docker images build properly, then this is ready to merge. I've tested it locally to ensure local builds from main now use latest images from DockerHub.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker labels Jul 24, 2023
@tdonohue tdonohue added this to the 8.0 milestone Jul 24, 2023
@tdonohue tdonohue self-assigned this Jul 24, 2023
@tdonohue
Copy link
Copy Markdown
Member Author

Merging immediately as this is required for Docker to continue to work proper on main. All test Docker builds worked (see automated checks)

@tdonohue tdonohue merged commit 44b197a into DSpace:main Jul 24, 2023
@tdonohue tdonohue deleted the docker_version_fixes branch July 24, 2023 21:54
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Oct 22, 2024
…Space#2394)

[DSC-1864] Merge tag 'dspace-7.6.2' into task/dspace-cris-2023_02_x/DSC-1864_re-worked

Approved-by: Andrea Barbasso
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant