Fix inherit policies at item move (Angular)#2423
Merged
tdonohue merged 3 commits intoDSpace:mainfrom Oct 25, 2023
Merged
Conversation
8 tasks
e39cadf to
1f68fd6
Compare
This was referenced Aug 24, 2023
tdonohue
approved these changes
Oct 25, 2023
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @KoenP ! This looks good and I tested it alongside DSpace/DSpace#9019 Works as described!
Member
|
Ported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Adds a tooltip to the "Inherit policies" checkbox on the "item move" page informing the user about the meaning of this option and warning them that the operation cannot be undone.
Instructions for Reviewers
Changes
ItemMoveComponenttemplate: Adds a tooltip toinheritPoliciesCheckbox.Testing
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.