Skip to content

Fix mouse cursor on language dropdown menu#2525

Merged
alanorth merged 1 commit intoDSpace:mainfrom
4Science:DURACOM-185
Sep 26, 2023
Merged

Fix mouse cursor on language dropdown menu#2525
alanorth merged 1 commit intoDSpace:mainfrom
4Science:DURACOM-185

Conversation

@davide-negretti
Copy link
Copy Markdown
Contributor

Description

The mouse cursor over items in the language selection menu is currently an arrow ↖. This PR replaces it with the more appropriate pointer 👆🏼.

image

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alanorth
Copy link
Copy Markdown
Contributor

alanorth commented Sep 26, 2023

Yes this is minor, but seems correct. And we do already use a pointer for the menu items in the Browse dropdown.

Also, after a quick survey of several websites shows that a pointer 👆🏼 is indeed more common for buttons and icons—just look here on GitHub!

I'm +1 by code review.

Edit: tested patch for good measure and it works as expected.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Sep 26, 2023
@alanorth alanorth self-requested a review September 26, 2023 18:39
@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Sep 27, 2023
@tdonohue tdonohue added this to the 8.0 milestone Sep 27, 2023
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Nov 11, 2024
[DSC-1847][DSC-1966] fix navbar ui error

Approved-by: Francesco Molinaro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants