Fix mouse cursor on language dropdown menu#2525
Merged
alanorth merged 1 commit intoDSpace:mainfrom Sep 26, 2023
Merged
Conversation
Contributor
|
Yes this is minor, but seems correct. And we do already use a pointer for the menu items in the Browse dropdown. Also, after a quick survey of several websites shows that a pointer 👆🏼 is indeed more common for buttons and icons—just look here on GitHub! I'm +1 by code review. Edit: tested patch for good measure and it works as expected. |
alanorth
approved these changes
Sep 26, 2023
Contributor
|
Successfully created backport PR for |
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Nov 11, 2024
[DSC-1847][DSC-1966] fix navbar ui error Approved-by: Francesco Molinaro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The mouse cursor over items in the language selection menu is currently an arrow ↖. This PR replaces it with the more appropriate pointer 👆🏼.
Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.