File edit component updated to work for forms without access conditions.#2647
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Feb 15, 2024
Merged
File edit component updated to work for forms without access conditions.#2647tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue merged 1 commit intoDSpace:mainfrom
Conversation
Fixed unit test Fixed accidental reformatting
nwoodward
approved these changes
Jan 19, 2024
Contributor
nwoodward
left a comment
There was a problem hiding this comment.
👍 Admittedly, I'm not sure why someone would remove all of the access conditions, but when I did so and deployed this locally it fixed the problem. The code looks good.
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix. Saving bitstream edits is failing when the submission form does not include access conditions. This PR adds a check that prevents access condition processing when the property doesn't exist in the form.
Instructions for Reviewers
This can be tested by removing access options from the
UploadConfiguration(by removing all "ref" tags). Then upload and edit a bitstream in the submission form. Try to save the changes. Prior to applying this PR you should see an error in console.Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.