Skip to content

Conversation

@alexandrevryghem
Copy link
Member

References

Description

MetadataSchemaComponent should always unslect all the checkboxes when switching to a different schema in the registry.

Instructions for Reviewers

List of changes in this PR:

  • Deselect all the fields from the MetadataSchemaComponent when destroying the component, this is needed because they are stored in the ngrx store.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem self-assigned this Nov 18, 2023
@alexandrevryghem alexandrevryghem added bug component: administrative tools Related to the admin menu or tools medium priority claimed: Atmire Atmire team is working on this issue & will contribute back labels Nov 18, 2023
@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Nov 21, 2023
@alanorth
Copy link
Contributor

Thanks, @alexandrevryghem! I tested this on DSpace 7.6.1 and it fixes the issue.

@dspace-bot
Copy link
Contributor

@alanorth alanorth removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Nov 23, 2023
@alanorth alanorth added this to the 8.0 milestone Nov 23, 2023
@alexandrevryghem alexandrevryghem deleted the deslect-metadata-fields-from-different-shemas_contribute-main branch June 24, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug claimed: Atmire Atmire team is working on this issue & will contribute back component: administrative tools Related to the admin menu or tools medium priority

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

delete metadatafields from multiple metadataschema

4 participants