-
Notifications
You must be signed in to change notification settings - Fork 504
Created new custom search scope context #2657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created new custom search scope context #2657
Conversation
…' into w2p-108608_created-search-scope-selector_contribute-main # Conflicts: # src/app/core/shared/context.model.ts # src/app/shared/search-form/scope-selector-modal/scope-selector-modal.component.html # src/app/shared/search-form/scope-selector-modal/scope-selector-modal.component.ts
|
Hi @alexandrevryghem, |
…search-scope-selector_contribute-main # Conflicts: # src/app/shared/search-form/scope-selector-modal/scope-selector-modal.component.ts
|
@alexandrevryghem : Should this still be considered for 8.0? If so, could I ask you to update this PR on latest |
|
@tdonohue: I synced it with |
|
Hi @alexandrevryghem, |
a745cd4 to
196a8c2
Compare
|
I have tested the The entire customization is working as expected. Additionally, when using the special theme exclusively for CommunitySidebarSearchListElementComponent, it behaves as intended for that specific type. The code also looks good to me. |
tdonohue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @alexandrevryghem ! Code looks good and I gave it some light testing (noticing no changes in behavior). I also trust the more detailed tests from @pcg-kk .


Description
Currently the same search results is used for all the admin sidebar modals (create/edit Community/Collection/Item) and the search in scope modal. This PR adds an easy way to only modify the search results in one of those two types of modals by creating a new
Context.ScopeSelectorModal&Context.ScopeSelectorModalCurrent.Instructions for Reviewers
List of changes in this PR:
Context.ScopeSelectorModal&Context.ScopeSelectorModalCurrentDSOSelectorComponent, if none is provided it will assume that you are using aContext.SideBarSearchModal.SidebarSearchListElementComponentand added a new@listableObjectComponentdecorator with the newly createdContext.ScopeSelectorModal&Context.ScopeSelectorModalCurrent. This way everything still works like it did before, but now it can also be customizedInclude guidance for how to test or review your PR.
CommunitySidebarSearchListElementComponentin your themes but only add the decorators ofContext.ScopeSelectorModal&Context.ScopeSelectorModalCurrentAll of DSpacebuttonChecklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.