[Docker] Refactor to simply use the reusable-docker-build.yml from DSpace/DSpace.#2666
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Nov 29, 2023
Merged
Conversation
tdonohue
added
code task
1 APPROVAL
Member
Author
|
Ported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In DSpace/DSpace#9213 a new
reusable-docker-build.ymlwas created for DSpace/DSpace at https://github.com/DSpace/DSpace/blob/main/.github/workflows/reusable-docker-build.ymlThis was based on refactoring in
dspace-angularin #2644. Therefore, as a final refactor fordspace-angular, we can easily update thedocker.ymlscript to use thatreusable-docker-build.yml.This PR makes that refactor. A similar PR will be needed for
dspace-7_xto use thedspace-7_xversion ofreusable-docker-build.yml